> On March 1, 2013, 7:25 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1567 > > <https://reviews.apache.org/r/8763/diff/4/?file=263196#file263196line1567> > > > > can you put the isError case first? seems to the pattern we follow in > > general > > Vinod Kone wrote: > Whenever possible, I like to keep the stuff that is more important, > upfront.
I see, but the convention in mesos has been to handle the error upfront, which makes this harder to read, since it's breaking that convention. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8763/#review17252 ----------------------------------------------------------- On March 4, 2013, 1:34 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8763/ > ----------------------------------------------------------- > > (Updated March 4, 2013, 1:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This checks slave info compatibility. Doesn't check version compatibility yet > (because its not clear how we get that info). > > > Diffs > ----- > > src/common/type_utils.hpp fde69aeec403b3455839dca6b0b2e1507d81ba00 > src/slave/paths.hpp fbf3fd84fb8f2590311b18d2afec2d2e0d30ef0a > src/slave/slave.hpp 7648c33230c1900eda7529045c5df9ccab105d47 > src/slave/slave.cpp c13d268c5e0e107902f64e30304a18128927a571 > src/tests/slave_recovery_tests.cpp PRE-CREATION > third_party/libprocess/third_party/stout/include/stout/os.hpp > da14a8fb95b69684c899e04ca79a1ad8eb11b2b8 > > Diff: https://reviews.apache.org/r/8763/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
