> On March 1, 2013, 7:25 p.m., Ben Mahler wrote: > > src/common/type_utils.hpp, line 258 > > <https://reviews.apache.org/r/8763/diff/4/?file=263193#file263193line258> > > > > Again, I really hate these equality operators as they are really > > brittle to changes!! > > > > I don't see why you need this level of equality either.. you're saying > > changing the resources or attributes is incompatible? > > > > Changing the webui port is incompatible?
Yes. The current semantics are that a master associates a slave based on its id and info. If anything in the info changes, it is potentially a different slave. > On March 1, 2013, 7:25 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1567 > > <https://reviews.apache.org/r/8763/diff/4/?file=263196#file263196line1567> > > > > can you put the isError case first? seems to the pattern we follow in > > general Whenever possible, I like to keep the stuff that is more important, upfront. > On March 1, 2013, 7:25 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1717 > > <https://reviews.apache.org/r/8763/diff/4/?file=263196#file263196line1717> > > > > is there a better way to capture incompatible upgrades, other than > > doing our own full equality comparison of the slave info? As the TODO suggests, a version compatibility check is also useful. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8763/#review17252 ----------------------------------------------------------- On Feb. 27, 2013, 11:38 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8763/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 11:38 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This checks slave info compatibility. Doesn't check version compatibility yet > (because its not clear how we get that info). > > > Diffs > ----- > > src/common/type_utils.hpp fde69aeec403b3455839dca6b0b2e1507d81ba00 > src/slave/paths.hpp fbf3fd84fb8f2590311b18d2afec2d2e0d30ef0a > src/slave/slave.hpp 7648c33230c1900eda7529045c5df9ccab105d47 > src/slave/slave.cpp 8c2e1bfc363491c681177676f9dfe5f229276f7d > src/tests/slave_recovery_tests.cpp PRE-CREATION > third_party/libprocess/include/stout/os.hpp > 32638ee273492550491b85223cda8e7a5bde7fa5 > > Diff: https://reviews.apache.org/r/8763/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
