> On Feb. 27, 2013, 1:31 a.m., Vinod Kone wrote: > > src/slave/monitor.cpp, line 208 > > <https://reviews.apache.org/r/9640/diff/1/?file=262943#file262943line208> > > > > put quotes around executorId since it can contain spaces.
Ok done for both executorId and frameworkId. We should really restrict the characters allowed in executorIds and frameworkIds. As in stands, they can put in anything, including spaces, tabs, slashes (which messes with the filesystem and the way I use statistics). I'll file a bug for this. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9640/#review17127 ----------------------------------------------------------- On Feb. 27, 2013, 1:09 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9640/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 1:09 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > We saw that the const Duration in the header was uninitialized. We saw this > issue before, which prompted the creation of constants.cpp. > > > Diffs > ----- > > src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c > src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 > src/slave/flags.hpp d4aa04556bd4cf33cbbc7e82b0c4413fc6fdf2dc > src/slave/monitor.cpp 16a555c15014bd964003be0666908ae1720bf1fc > > Diff: https://reviews.apache.org/r/9640/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
