----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9640/#review17129 -----------------------------------------------------------
Ship it! src/slave/flags.hpp <https://reviews.apache.org/r/9640/#comment36279> I'm sorry I missed this one before, it should have always gone in constants.cpp. BTW, can you use this value in your test as well? src/slave/monitor.cpp <https://reviews.apache.org/r/9640/#comment36280> This seems rather noisy ... a log line for every executor every five seconds? Maybe VLOG? src/slave/monitor.cpp <https://reviews.apache.org/r/9640/#comment36282> This one makes sense to be a LOG(WARNING) since it probably isn't happening that often. And note the absence of this log line implies are "working". ;) - Benjamin Hindman On Feb. 27, 2013, 1:37 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9640/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 1:37 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > We saw that the const Duration in the header was uninitialized. We saw this > issue before, which prompted the creation of constants.cpp. > > > Diffs > ----- > > src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c > src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 > src/slave/flags.hpp d4aa04556bd4cf33cbbc7e82b0c4413fc6fdf2dc > src/slave/monitor.cpp 16a555c15014bd964003be0666908ae1720bf1fc > > Diff: https://reviews.apache.org/r/9640/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
