> On Feb. 27, 2013, 1:39 a.m., Benjamin Hindman wrote: > > src/slave/monitor.cpp, line 208 > > <https://reviews.apache.org/r/9640/diff/1/?file=262943#file262943line208> > > > > This seems rather noisy ... a log line for every executor every five > > seconds? Maybe VLOG?
You should see the allocator logging!! ;) Changed to VLOG(1). > On Feb. 27, 2013, 1:39 a.m., Benjamin Hindman wrote: > > src/slave/flags.hpp, line 36 > > <https://reviews.apache.org/r/9640/diff/1/?file=262942#file262942line36> > > > > I'm sorry I missed this one before, it should have always gone in > > constants.cpp. BTW, can you use this value in your test as well? done in the other change > On Feb. 27, 2013, 1:39 a.m., Benjamin Hindman wrote: > > src/slave/monitor.cpp, line 212 > > <https://reviews.apache.org/r/9640/diff/1/?file=262943#file262943line212> > > > > This one makes sense to be a LOG(WARNING) since it probably isn't > > happening that often. And note the absence of this log line implies are > > "working". ;) Yeah, I guess I just got scared and added the LOG(INFO) because the spinning was un-noticed! Can't wait till we get off gcc 4.1.2. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9640/#review17129 ----------------------------------------------------------- On Feb. 27, 2013, 1:37 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9640/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 1:37 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > We saw that the const Duration in the header was uninitialized. We saw this > issue before, which prompted the creation of constants.cpp. > > > Diffs > ----- > > src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c > src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 > src/slave/flags.hpp d4aa04556bd4cf33cbbc7e82b0c4413fc6fdf2dc > src/slave/monitor.cpp 16a555c15014bd964003be0666908ae1720bf1fc > > Diff: https://reviews.apache.org/r/9640/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
