----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9797/#review17631 -----------------------------------------------------------
src/tests/isolator_tests.cpp <https://reviews.apache.org/r/9797/#comment37390> I'm confused. Where did these numbers come from!? How can you guarantee the stats are going to be greater than these? src/tests/utils.hpp <https://reviews.apache.org/r/9797/#comment37382> s/it/them/ src/tests/utils.hpp <https://reviews.apache.org/r/9797/#comment37385> Using CHECK's in tests is bad, because 1) TearDown* methods won't be called and 2) no other tests will be run. Typically, a test failure should only abort the current test and proceed with other tests. tl:dr; s/CHECK_SOME/ASSERT/ src/tests/utils.hpp <https://reviews.apache.org/r/9797/#comment37386> ditto src/tests/utils.hpp <https://reviews.apache.org/r/9797/#comment37387> ditto src/tests/utils.hpp <https://reviews.apache.org/r/9797/#comment37388> ditto - Vinod Kone On March 8, 2013, 2:28 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9797/ > ----------------------------------------------------------- > > (Updated March 8, 2013, 2:28 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Finally some non-external isolation module tests! > > > Diffs > ----- > > src/Makefile.am f7242a7fb55de3d1df4930126345274124331d57 > src/tests/environment.cpp bda72ae0310e74015f3fbde50fecbf6515276e81 > src/tests/isolator_tests.cpp PRE-CREATION > src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541 > > Diff: https://reviews.apache.org/r/9797/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
