----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9797/#review17818 -----------------------------------------------------------
src/tests/isolator_tests.cpp <https://reviews.apache.org/r/9797/#comment37780> I think you can make this work more clearly with a 'do { ... } while (waited < Seconds(5));' and then put the EXPECT_GT after the loop. - Benjamin Hindman On March 13, 2013, 12:21 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9797/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 12:21 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Finally some non-external isolation module tests! > > > Diffs > ----- > > src/Makefile.am f7242a7fb55de3d1df4930126345274124331d57 > src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6 > src/tests/isolator_tests.cpp PRE-CREATION > src/tests/utils.hpp d3efa58ef62383af9eb051b23feb950ba6a4f4e3 > > Diff: https://reviews.apache.org/r/9797/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
