> On March 8, 2013, 9:48 p.m., Vinod Kone wrote: > > src/tests/isolator_tests.cpp, lines 180-182 > > <https://reviews.apache.org/r/9797/diff/1-2/?file=267815#file267815line180> > > > > I'm confused. Where did these numbers come from!? > > > > How can you guarantee the stats are going to be greater than these?
I've now made the test even more robust! So it will start the child 'top' process and allow up to 5 seconds for the cpu times to be induced. Note that this test will fail on OSX, until I fix the child process monitoring to handle OSX as well. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9797/#review17631 ----------------------------------------------------------- On March 8, 2013, 2:28 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9797/ > ----------------------------------------------------------- > > (Updated March 8, 2013, 2:28 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Finally some non-external isolation module tests! > > > Diffs > ----- > > src/Makefile.am f7242a7fb55de3d1df4930126345274124331d57 > src/tests/environment.cpp bda72ae0310e74015f3fbde50fecbf6515276e81 > src/tests/isolator_tests.cpp PRE-CREATION > src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541 > > Diff: https://reviews.apache.org/r/9797/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
