-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9464/
-----------------------------------------------------------
(Updated March 26, 2013, 11:44 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Rebased off trunk and changed flag behavior to be an explicit flag instead of a
"feature list." Nested handlers remain.
Description
-------
Initial support for CPU "hard limits" via CFS Bandwidth Control in cgroups.
CFS is unique relative to existing Mesos cgroups support in that it is a
"subfeature" of an already supported cgroups subsystem, cpu. Also, there are
two "tunables" for configuring CFS bandwidth limiting.
There are 4 approaches one could take:
1) Use the CFS bandwidth limiting if the feature is present
2) Expose as separate flag, eg "cpu,cfs,memory,freezer"
3) Add feature flag support to subsystems via an additional delimiter, eg
"cpu+cfs,memory,freezer".
4) Add an additional control flag via some other means
Option 2's downside breaks the 1:1 mapping between cgroups subsystems and a
cgroups resource flag.
Option 3's downside is it greatly increases complexity of parsing cgroups
subsystem flags.
This diff takes option 1.
This addresses bug MESOS-315.
https://issues.apache.org/jira/browse/MESOS-315
Diffs (updated)
-----
src/slave/cgroups_isolator.hpp 1732c4e
src/slave/cgroups_isolator.cpp ebc2843
src/slave/flags.hpp 95969ae
third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp
a8feabd
Diff: https://reviews.apache.org/r/9464/diff/
Testing
-------
make check + additional testing
Thanks,
David Mackey
