----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9464/#review18412 -----------------------------------------------------------
Ship it! Modulo comments below. src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/9464/#comment38611> Let's keep this consistent with other messages from initialize(), so: s/The/Your src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/9464/#comment38615> What is the "parent handler"? I think you can just say "Set the cpu shares as well" to be clear as to what the parent handler is doing. src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/9464/#comment38612> Does this need to be namespaced? src/slave/flags.hpp <https://reviews.apache.org/r/9464/#comment38613> s/ (cgroups_enable_cfs=true)// src/slave/flags.hpp <https://reviews.apache.org/r/9464/#comment38614> s/true/false We definitely don't want to enable by default initially. - Ben Mahler On March 26, 2013, 11:44 p.m., David Mackey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9464/ > ----------------------------------------------------------- > > (Updated March 26, 2013, 11:44 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > Initial support for CPU "hard limits" via CFS Bandwidth Control in cgroups. > > CFS is unique relative to existing Mesos cgroups support in that it is a > "subfeature" of an already supported cgroups subsystem, cpu. Also, there are > two "tunables" for configuring CFS bandwidth limiting. > > There are 4 approaches one could take: > 1) Use the CFS bandwidth limiting if the feature is present > 2) Expose as separate flag, eg "cpu,cfs,memory,freezer" > 3) Add feature flag support to subsystems via an additional delimiter, eg > "cpu+cfs,memory,freezer". > 4) Add an additional control flag via some other means > > Option 2's downside breaks the 1:1 mapping between cgroups subsystems and a > cgroups resource flag. > Option 3's downside is it greatly increases complexity of parsing cgroups > subsystem flags. > > This diff takes option 1. > > > This addresses bug MESOS-315. > https://issues.apache.org/jira/browse/MESOS-315 > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp 1732c4e > src/slave/cgroups_isolator.cpp ebc2843 > src/slave/flags.hpp 95969ae > third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp > a8feabd > > Diff: https://reviews.apache.org/r/9464/diff/ > > > Testing > ------- > > make check + additional testing > > > Thanks, > > David Mackey > >
