----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10346/#review18797 -----------------------------------------------------------
hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39238> i wasn't able to confirm whether skipping the compression level while extracting always works with all versions of tar. so, lets stick with specifying it (here it is 'z') unless we are sure. i'm going to revert my change in the launcher (in a review that i sent last week) to do the same. hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39239> Is this required by the pre-package script? If yes, please add a comment here. hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39240> Are these scripts only applicable for Cloudera versions? If yes, may be we can just test against that, like we do everywhere else. hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39242> What compression does J represent? It doesn't work on my MAC (OSX 10.8). How about.. s/-cjf/-czf/ hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39241> same, as earlier comment. test against distribution version? hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39243> I think you added this because the jobtracker was failing on your Mac? I would rather we find and fix that bug, than having to skip it. It just sets a better precedent for our code. Can you file a bug (with a stack trace and logs) on your tutorial output? hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch <https://reviews.apache.org/r/10346/#comment39244> We definitely want to be able to run this both locally and on the cluster. And your change, would render local runs in a non-working state. I've sent a review out that should work for both local and remote runs. I will get it committed. You can base your changes off that to patch cdh4.2.0_hadoop-env.sh. src/launcher/launcher.cpp <https://reviews.apache.org/r/10346/#comment39245> per my comment above, does this work with all versions of tar on all types of *nixes? - Vinod Kone On April 8, 2013, 9:21 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10346/ > ----------------------------------------------------------- > > (Updated April 8, 2013, 9:21 p.m.) > > > Review request for mesos. > > > Description > ------- > > - Added CDH4.2.0 support to TUTORIAL.sh > - Use .tar.xz for Hadoop dist (LZMA) > - Fixed Hadoop dist extraction in launcher > - Add pre/post packaging hooks to TUTORIAL.sh > - Don't run the jobtracker at the end by default > > > Diffs > ----- > > hadoop/Makefile.am bd8919a > hadoop/TUTORIAL.sh b0f77f3 > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch c61ccec > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch PRE-CREATION > src/launcher/launcher.cpp eb8d6fb > > Diff: https://reviews.apache.org/r/10346/diff/ > > > Testing > ------- > > Works in production on Hadoop at airbnb. > > > Thanks, > > Brenden Matthews > >
