> On April 8, 2013, 9:55 p.m., Vinod Kone wrote: > > > > Ben Mahler wrote: > Hey Brenden, will you be updating this review based on the comments? > > Brenden Matthews wrote: > Yes, I'll try and finish it up this afternoon. > > Vinod Kone wrote: > Cool. Make sure to rebase off the latest trunk, to get the latest hadoop > fixes. > > Ben Mahler wrote: > Hey Brenden, I'm happy to give this a review for you, can you first > update the issues Vinod has raised below? (By either marked them as 'Fixed' > or 'Dropped'?)
I can't figure out how to use Review Board. When I click "Fixed" or "Drop" nothing happens. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10346/#review18797 ----------------------------------------------------------- On April 9, 2013, 10:36 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10346/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 10:36 p.m.) > > > Review request for mesos. > > > Description > ------- > > - Added CDH4.2.0 support to TUTORIAL.sh > - Fixed Hadoop dist extraction in launcher > - Add pre/post packaging hooks to TUTORIAL.sh > - Don't run the jobtracker at the end by default if ${SKIP_TESTS} > defined > > > Diffs > ----- > > hadoop/Makefile.am bd8919a > hadoop/TUTORIAL.sh f3f3d64 > hadoop/hadoop-0.20.2-cdh3u3_hadoop-env.sh.patch fb8b06b > hadoop/hadoop-0.20.205.0_hadoop-env.sh.patch 8f67ff9 > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch 6d31578 > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch PRE-CREATION > src/launcher/launcher.cpp bc50c5f > > Diff: https://reviews.apache.org/r/10346/diff/ > > > Testing > ------- > > Works in production on Hadoop at airbnb. > > > Thanks, > > Brenden Matthews > >
