----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10346/#review19146 -----------------------------------------------------------
Hey Brenden, note that if you'd like to speed up the review process, you could split up the changes you listed in the description into separate reviews. We use a tool to help with doing chained reviews, you can find it here: support/post-reviews.py. Let me know if you'd like to try it out or need any help! hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39712> I'm not sold on this, we can't have any Airbnb specific code in here. hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39714> Ditto. hadoop/TUTORIAL.sh <https://reviews.apache.org/r/10346/#comment39717> This is the essence of the TUTORIAL, more so than being a build file, it is about providing users with a tutorial, so they can see what commands we ran to produce a working setup. So I'm skeptical of adding this. I think you should be writing custom build scripts for your particular Airbnb setup, rather than using the TUTORIAL.sh as a build file. Do you have a convincing argument otherwise? src/launcher/launcher.cpp <https://reviews.apache.org/r/10346/#comment39718> Can you confirm 'tar xjf' and 'tar xJf' both work on OSX? If not we either need to kill them or guard them with #ifdefs. - Ben Mahler On April 9, 2013, 10:36 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10346/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 10:36 p.m.) > > > Review request for mesos. > > > Description > ------- > > - Added CDH4.2.0 support to TUTORIAL.sh > - Fixed Hadoop dist extraction in launcher > - Add pre/post packaging hooks to TUTORIAL.sh > - Don't run the jobtracker at the end by default if ${SKIP_TESTS} > defined > > > Diffs > ----- > > hadoop/Makefile.am bd8919a > hadoop/TUTORIAL.sh f3f3d64 > hadoop/hadoop-0.20.2-cdh3u3_hadoop-env.sh.patch fb8b06b > hadoop/hadoop-0.20.205.0_hadoop-env.sh.patch 8f67ff9 > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch 6d31578 > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch PRE-CREATION > src/launcher/launcher.cpp bc50c5f > > Diff: https://reviews.apache.org/r/10346/diff/ > > > Testing > ------- > > Works in production on Hadoop at airbnb. > > > Thanks, > > Brenden Matthews > >
