----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10268/#review19212 -----------------------------------------------------------
src/slave/slave.hpp <https://reviews.apache.org/r/10268/#comment39786> As discussed, s/CONNECTING/DISCONNECTED/. Which matches the semantics nicely :) I like CONNECTING but as discussed it is the case that we can be in CONNECTING but not be actively connecting to the master. src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39787> Since this sets the trend, do we always want to use braces, or only when necessary? Do you see any danger of omitting them when not needed? I think it would be nice to eliminate all the extra lines needed for the closing braces, if possible. src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39788> Can you add a TODO to only subscribe to master detection _after_ recovery? src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39789> Ditto for a TODO to unsubscribe for master detection upon termination? Or is there a reason we might want to be notified of new masters during termination? src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39792> Remove the brace src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39793> Remove brace src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39797> no return? src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39795> else if? src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39794> bad indents here src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39796> no return? src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39798> no return? - Ben Mahler On April 15, 2013, 6:04 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10268/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 6:04 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > > Diff: https://reviews.apache.org/r/10268/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
