----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10268/#review19284 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39943> kill TODO src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39944> kill TODO src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39945> DISCONNECTED src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39946> move this down below the CHECK src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39947> kill this src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39948> Dropping (as you formatted above)? src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39949> Ditto on single lines. src/slave/slave.cpp <https://reviews.apache.org/r/10268/#comment39950> Ditto on this or default, but not both. Depends how gcc complains. - Ben Mahler On April 16, 2013, 1:40 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10268/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 1:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp eaabf432be5417905b22bae6b9ddbee70406a990 > src/slave/process_isolator.hpp 920a667bb2ecc4c497ada39020579012110d9204 > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > > Diff: https://reviews.apache.org/r/10268/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
