> On April 15, 2013, 7:22 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 556 > > <https://reviews.apache.org/r/10268/diff/2/?file=281135#file281135line556> > > > > Since this sets the trend, do we always want to use braces, or only > > when necessary? Do you see any danger of omitting them when not needed? > > > > I think it would be nice to eliminate all the extra lines needed for > > the closing braces, if possible.
Sure. I hated those braces too. I'm gonna fix it to use braces only when necessary. > On April 15, 2013, 7:22 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 590 > > <https://reviews.apache.org/r/10268/diff/2/?file=281135#file281135line590> > > > > Ditto for a TODO to unsubscribe for master detection upon termination? > > > > Or is there a reason we might want to be notified of new masters during > > termination? Not really. Added a TODO. > On April 15, 2013, 7:22 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1307 > > <https://reviews.apache.org/r/10268/diff/2/?file=281135#file281135line1307> > > > > no return? thank you. > On April 15, 2013, 7:22 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1310 > > <https://reviews.apache.org/r/10268/diff/2/?file=281135#file281135line1310> > > > > else if? We allow executors to register if the slave is running/disconnected. Were you expecting something else? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10268/#review19212 ----------------------------------------------------------- On April 15, 2013, 6:04 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10268/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 6:04 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > > Diff: https://reviews.apache.org/r/10268/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
