> On April 16, 2013, 6:25 p.m., Vinod Kone wrote: > > src/detector/detector.hpp, line 45 > > <https://reviews.apache.org/r/10161/diff/2/?file=281414#file281414line45> > > > > Why did you kill the comment? This has been our convention.
> On April 16, 2013, 6:25 p.m., Vinod Kone wrote: > > src/tests/zookeeper_tests.cpp, lines 307-310 > > <https://reviews.apache.org/r/10161/diff/2/?file=281416#file281416line307> > > > > I like this test! > > > > But, wouldn't this test pass even with old code? > > > > I thought (correct me if I'm wrong) this patch makes sure a non-leading > > master gets NoMasterDetected message? If yes, a test for that would be > > great. > On April 16, 2013, 6:25 p.m., Vinod Kone wrote: > > src/tests/zookeeper_tests.cpp, line 339 > > <https://reviews.apache.org/r/10161/diff/2/?file=281416#file281416line339> > > > > Is there a reason why you had specifically match to detector.process > > and not just "_"? if you can use "_" here then you can make process back to > > private. This is not a match, this is actually dispatching, I couldn't find a way to induce the reconnection call otherwise. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10161/#review19264 ----------------------------------------------------------- On April 16, 2013, 12:40 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10161/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 12:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This is also along the way to fixing MESOS-305. > > This fixes a bug where we were not clearing the sequence number when sending > a NoMasterDetectedMessage. > As a result, this removes the need for hiding NoMasterDetectedMessages from > contending non-leaders. > > > Diffs > ----- > > src/detector/detector.hpp ed485bd86d2bff1046a234a5776c1081a4136bc5 > src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 > src/tests/zookeeper_tests.cpp 37e1b77a9c728034936eddd451c75a46605885db > > Diff: https://reviews.apache.org/r/10161/diff/ > > > Testing > ------- > > make check > > I'd like to add a test for this, but I don't see how to induce a timedout() > call on the ZooKeeperMasterDetectorProcess, unless I add some plumbing to get > a handle to the underlying process. Suggestions? > > > Thanks, > > Ben Mahler > >
