----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10161/#review19903 -----------------------------------------------------------
Ship it! src/detector/detector.cpp <https://reviews.apache.org/r/10161/#comment41058> s/10.0/10/ - Benjamin Hindman On April 24, 2013, 11:55 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10161/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 11:55 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This is also along the way to fixing MESOS-305. > > This fixes a bug where we were not clearing the sequence number when sending > a NoMasterDetectedMessage. > As a result, this removes the need for hiding NoMasterDetectedMessages from > contending non-leaders. > > > Diffs > ----- > > src/detector/detector.hpp ed485bd86d2bff1046a234a5776c1081a4136bc5 > src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 > src/tests/zookeeper_tests.cpp 125b16566d5cd59732fef67d80617724ff71433b > > Diff: https://reviews.apache.org/r/10161/diff/ > > > Testing > ------- > > make check > > I'd like to add a test for this, but I don't see how to induce a timedout() > call on the ZooKeeperMasterDetectorProcess, unless I add some plumbing to get > a handle to the underlying process. Suggestions? > > > Thanks, > > Ben Mahler > >
