> On April 16, 2013, 7:02 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 270 > > <https://reviews.apache.org/r/10172/diff/2/?file=281465#file281465line270> > > > > did you forget to kill this?
I will be renaming 'connected' to 'activated' in the next review: https://reviews.apache.org/r/10534/ > On April 16, 2013, 7:02 p.m., Vinod Kone wrote: > > src/tests/fault_tolerance_tests.cpp, line 231 > > <https://reviews.apache.org/r/10172/diff/2/?file=281468#file281468line231> > > > > s/Process/process/ ? Well.. I want to be clear that I'm referring to a libprocess "Process". > On April 16, 2013, 7:02 p.m., Vinod Kone wrote: > > src/tests/fault_tolerance_tests.cpp, line 305 > > <https://reviews.apache.org/r/10172/diff/2/?file=281468#file281468line305> > > > > You could simplify this by while(lostStatus.isPending()). > > > > But I will leave it up to you. Punting for now, I want to be explicit about the pings, I also borrowed this from other tests (I know, no excuse ;)). - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10172/#review19267 ----------------------------------------------------------- On April 16, 2013, 12:58 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10172/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 12:58 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. This is a fix of MESOS-305. > > This also fixes MESOS-362. > > > This addresses bugs MESOS-305 and MESOS-362. > https://issues.apache.org/jira/browse/MESOS-305 > https://issues.apache.org/jira/browse/MESOS-362 > > > Diffs > ----- > > src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 > src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed > src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 > src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c > src/tests/fault_tolerance_tests.cpp > bfb30344ca02cd42c442a373d44d6a3fa287c1e3 > src/tests/master_detector_tests.cpp > 980f3c720301b83af668e10f479adb9cce4f0c9f > > Diff: https://reviews.apache.org/r/10172/diff/ > > > Testing > ------- > > make check > > Added tests for the partitioned slave re-registration. > ./bin/mesos-tests.sh > --gtest_filter="FaultToleranceTest.PartitionedSlaveReregistration" --verbose > --gtest_break_on_failure --gtest_repeat=3000 > > Ran into MESOS-406, but otherwise no issues. > > Will be adding ZK master detector tests shortly to test that the > NoMasterDetectedMessages are being sent. > > > Thanks, > > Ben Mahler > >
