----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10172/#review19468 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/10172/#comment40214> not yours, but could you add slave id, pid and hostname to the log message? src/master/master.cpp <https://reviews.apache.org/r/10172/#comment40213> ditto - Vinod Kone On April 19, 2013, 6:54 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10172/ > ----------------------------------------------------------- > > (Updated April 19, 2013, 6:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. This is a fix of MESOS-305. > > This also fixes MESOS-362. > > > This addresses bugs MESOS-305 and MESOS-362. > https://issues.apache.org/jira/browse/MESOS-305 > https://issues.apache.org/jira/browse/MESOS-362 > > > Diffs > ----- > > src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 > src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed > src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 > src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c > src/tests/fault_tolerance_tests.cpp > 0348f20a8f4333f7d2f3786c33e55713cbcbcbe0 > src/tests/master_detector_tests.cpp > 980f3c720301b83af668e10f479adb9cce4f0c9f > src/tests/zookeeper_tests.cpp 0855f5aee0baef22c4ecbed1b88f14f16bfff532 > > Diff: https://reviews.apache.org/r/10172/diff/ > > > Testing > ------- > > make check > > Added tests for the partitioned slave re-registration. > ./bin/mesos-tests.sh > --gtest_filter="FaultToleranceTest.PartitionedSlaveReregistration" --verbose > --gtest_break_on_failure --gtest_repeat=3000 > > Ran into MESOS-406, but otherwise no issues. > > Will be adding ZK master detector tests shortly to test that the > NoMasterDetectedMessages are being sent. > > > Thanks, > > Ben Mahler > >
