Re: Review Request: Send NoMasterDetectedMessage on session timeout to non-contending detectors. Added a disconnected slave map to the master to track disconnected slaves, in order to disallow slave re-registration after a network partition.

[Ben Mahler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10172/
-----------------------------------------------------------

(Updated April 24, 2013, 11:55 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased.


Description
-------

See above. This is a fix of MESOS-305.

This also fixes MESOS-362.


This addresses bugs MESOS-305 and MESOS-362.
    https://issues.apache.org/jira/browse/MESOS-305
    https://issues.apache.org/jira/browse/MESOS-362


Diffs (updated)
-----

  src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 
  src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
  src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 
  src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436 
  src/tests/fault_tolerance_tests.cpp d3476f7f5d1b7e2ed45385f5145eaccd6c114d21 
  src/tests/master_detector_tests.cpp b042d6ffb0c2e58c6c338de2b2534fc6b63f5f08 
  src/tests/zookeeper_tests.cpp 125b16566d5cd59732fef67d80617724ff71433b 

Diff: https://reviews.apache.org/r/10172/diff/


Testing
-------

make check

Added tests for the partitioned slave re-registration.
./bin/mesos-tests.sh 
--gtest_filter="FaultToleranceTest.PartitionedSlaveReregistration" --verbose 
--gtest_break_on_failure --gtest_repeat=3000

Ran into MESOS-406, but otherwise no issues.

Will be adding ZK master detector tests shortly to test that the 
NoMasterDetectedMessages are being sent.


Thanks,

Ben Mahler