> On April 17, 2013, 7:21 p.m., Ben Mahler wrote: > > src/master/hierarchical_allocator_process.hpp, line 99 > > <https://reviews.apache.org/r/6665/diff/14/?file=281663#file281663line99> > > > > Can this be const?
Correct me if I'm wrong, but we can't make this const unless we start saving the Slaves as pointers, since it makes the Slaves unassignable. > On April 17, 2013, 7:21 p.m., Ben Mahler wrote: > > src/master/hierarchical_allocator_process.hpp, line 116 > > <https://reviews.apache.org/r/6665/diff/14/?file=281663#file281663line116> > > > > Can this be const? Ditto. > On April 17, 2013, 7:21 p.m., Ben Mahler wrote: > > src/master/hierarchical_allocator_process.hpp, line 423 > > <https://reviews.apache.org/r/6665/diff/14/?file=281663#file281663line423> > > > > Would love to see a cleanup if this tricky filter deletion in a follow > > up! It's on my TODO list. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6665/#review19340 ----------------------------------------------------------- On April 16, 2013, 9:53 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6665/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 9:53 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > There has been an unfortunate trend in the HierarchicalAllocatorProcess code > to use lots of hashmaps between slaveIds or frameworkIds and some attribute > of those frameworks/slaves. This patch collapses those into two hashmaps, one > for slaves and one for frameworks, mapping ids to structs containing the > appropriate attributes. The patch also introduces an allocator namespace. > > > Diffs > ----- > > src/local/local.hpp 2633d25 > src/local/local.cpp f43ab2a > src/master/allocator.hpp b68b67d > src/master/drf_sorter.hpp 79566cc > src/master/drf_sorter.cpp fe31a00 > src/master/hierarchical_allocator_process.hpp 2422fbd > src/master/main.cpp d6e1c73 > src/master/master.hpp 9776a7c > src/master/master.cpp 5b0e8c0 > src/master/sorter.hpp 73db6b1 > src/tests/allocator_tests.cpp ca8d4ea > src/tests/allocator_zookeeper_tests.cpp 82a498e > src/tests/cluster.hpp 28fc269 > src/tests/fault_tolerance_tests.cpp 0348f20 > src/tests/isolator_tests.cpp 4a115c3 > src/tests/resource_offers_tests.cpp ad3640f > src/tests/slave_recovery_tests.cpp 7be332b > src/tests/sorter_tests.cpp 61e6038 > src/tests/utils.hpp b5c577d > third_party/libprocess/third_party/stout/include/stout/stringify.hpp > 136316d > > Diff: https://reviews.apache.org/r/6665/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
