----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6665/ -----------------------------------------------------------
(Updated May 9, 2013, 9:49 p.m.) Review request for mesos and Benjamin Hindman. Changes ------- Updated to trunk. Description ------- There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace. Diffs (updated) ----- src/local/local.hpp 2633d25 src/local/local.cpp f43ab2a src/master/allocator.hpp b68b67d src/master/drf_sorter.hpp 79566cc src/master/drf_sorter.cpp fe31a00 src/master/hierarchical_allocator_process.hpp 2422fbd src/master/main.cpp d6e1c73 src/master/master.hpp d3790dc src/master/master.cpp 3207157 src/master/sorter.hpp 73db6b1 src/tests/allocator_tests.cpp 540c05a src/tests/allocator_zookeeper_tests.cpp 2c7deb1 src/tests/cluster.hpp 682b7d6 src/tests/fault_tolerance_tests.cpp 68cd5fc src/tests/isolator_tests.cpp 435c780 src/tests/resource_offers_tests.cpp 5e53a89 src/tests/slave_recovery_tests.cpp d963ce1 src/tests/sorter_tests.cpp 95e8d28 src/tests/utils.hpp ca3ecd7 third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d Diff: https://reviews.apache.org/r/6665/diff/ Testing ------- On both OSX and Ubuntu (with this patch: https://reviews.apache.org/r/10786/ also applied) bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=2000 --gtest_filter=*Allocator* Thanks, Thomas Marshall
