> On April 17, 2013, 7:21 p.m., Ben Mahler wrote: > > src/master/hierarchical_allocator_process.hpp, line 99 > > <https://reviews.apache.org/r/6665/diff/14/?file=281663#file281663line99> > > > > Can this be const? > > Thomas Marshall wrote: > Correct me if I'm wrong, but we can't make this const unless we start > saving the Slaves as pointers, since it makes the Slaves unassignable.
Ah yes, thanks! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6665/#review19340 ----------------------------------------------------------- On April 26, 2013, 12:31 a.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6665/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 12:31 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > There has been an unfortunate trend in the HierarchicalAllocatorProcess code > to use lots of hashmaps between slaveIds or frameworkIds and some attribute > of those frameworks/slaves. This patch collapses those into two hashmaps, one > for slaves and one for frameworks, mapping ids to structs containing the > appropriate attributes. The patch also introduces an allocator namespace. > > > Diffs > ----- > > src/local/local.hpp 2633d25 > src/local/local.cpp f43ab2a > src/master/allocator.hpp b68b67d > src/master/drf_sorter.hpp 79566cc > src/master/drf_sorter.cpp fe31a00 > src/master/hierarchical_allocator_process.hpp 2422fbd > src/master/main.cpp d6e1c73 > src/master/master.hpp 9776a7c > src/master/master.cpp c3b26b1 > src/master/sorter.hpp 73db6b1 > src/tests/allocator_tests.cpp 540c05a > src/tests/allocator_zookeeper_tests.cpp 2c7deb1 > src/tests/cluster.hpp 682b7d6 > src/tests/fault_tolerance_tests.cpp d3476f7 > src/tests/isolator_tests.cpp 435c780 > src/tests/resource_offers_tests.cpp 5e53a89 > src/tests/slave_recovery_tests.cpp c1d2000 > src/tests/sorter_tests.cpp 95e8d28 > src/tests/utils.hpp ca3ecd7 > third_party/libprocess/third_party/stout/include/stout/stringify.hpp > 136316d > > Diff: https://reviews.apache.org/r/6665/diff/ > > > Testing > ------- > > On both OSX and Ubuntu (with this patch: https://reviews.apache.org/r/10786/ > also applied) > > bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=2000 > --gtest_filter=*Allocator* > > > Thanks, > > Thomas Marshall > >
