----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10932/#review20225 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/10932/#comment41470> s/running/ Can you also log a warning here indicating the reason for your kill? something like, LOG(WARNING) << "Killing the unregistered executor '" << executor->id << "' of framework " << framework->id << " because it has no tasks"; - Vinod Kone On May 6, 2013, 8:22 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10932/ > ----------------------------------------------------------- > > (Updated May 6, 2013, 8:22 p.m.) > > > Review request for mesos. > > > Description > ------- > > From 7eeef8e39de4b6ccd40aea4ebbd0f03d55fb10a3 Mon Sep 17 00:00:00 2001 > From: Brenden Matthews <[email protected]> > Date: Fri, 3 May 2013 09:47:22 -0700 > Subject: [PATCH 16/19] Terminate executors that aren't needed. > > If we launch an executor and then kill the task immediately after, make > sure we also terminate the executor when there are no other tasks. > --- > src/slave/slave.cpp | 48 +++++++++++++++++++++++++++--------------------- > 1 file changed, 27 insertions(+), 21 deletions(-) > > > Diffs > ----- > > src/slave/slave.cpp 86a15fc > > Diff: https://reviews.apache.org/r/10932/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
