----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11125/#review20718 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/11125/#comment42783> Add a LOG(WARNING) here indicating why you are killing the executor. - Vinod Kone On May 14, 2013, 12:20 a.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11125/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 12:20 a.m.) > > > Review request for mesos. > > > Description > ------- > > From 9c94ff131f7825b4152e5fe20f4a41fde6f4f951 Mon Sep 17 00:00:00 2001 > From: Brenden Matthews <[email protected]> > Date: Fri, 3 May 2013 09:47:22 -0700 > Subject: [PATCH 18/24] Terminate executors that aren't needed. > > If we launch an executor and then kill the task immediately after, make > sure we also terminate the executor when there are no other tasks. > > Review: https://reviews.apache.org/r/11125 > --- > src/slave/slave.cpp | 48 +++++++++++++++++++++++++++--------------------- > 1 file changed, 27 insertions(+), 21 deletions(-) > > > Diffs > ----- > > src/slave/slave.cpp d3126cc072cbf17cbc5cc18be4bfa4840886fb16 > > Diff: https://reviews.apache.org/r/11125/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
