----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11125/#review21371 -----------------------------------------------------------
Thanks! Want to take a stab at writing a test for this? We typically vet such changes using test cases as a first step. We currently do not have a tests/slave_tests.cpp (if you're up for it you can create one), alternatively you can sneak it into tests/fault_tolerance_tests.cpp for now with a TODO for creating slave_tests.cpp. We can provide additional pointers if needed! You'll want to do the following (much of this will be copied from existing tests): 1. Set up a master / slave. 2. Launch a task with an executor that never registers. 3. Send a killTask for that task. 4. Expect that the executorTerminated is called on the slave, using FUTURE_DISPATCH (in process/gmock.hpp). - Ben Mahler On June 3, 2013, 5:56 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11125/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 5:56 p.m.) > > > Review request for mesos. > > > Description > ------- > > Terminate executors that aren't needed. > > If we launch an executor and then kill the task immediately after, make > sure we also terminate the executor when there are no other tasks. > > Review: https://reviews.apache.org/r/11125 > > > Diffs > ----- > > src/slave/slave.cpp e905ab3cd965002592c1f70c85ea3378ac8982b0 > > Diff: https://reviews.apache.org/r/11125/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
