----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11206/ -----------------------------------------------------------
Review request for mesos and Benjamin Hindman. Description ------- Previously when we were doing hierarchical allocation by user, we created and removed user pools for allocation based on what users had frameworks currently running in the cluster. However, with the role abstraction it makes sense to have more persistence than that, especially once we add weights - if you set the weight for a role, you want the allocator to remember it even if there aren't any frameworks for that role currently running. So, I decided that it made sense to create a concept of specific roles that are allowable in the cluster. With this patch, its only possible to pass roles in to the master as a command line flag (to ease what I assume will be the common case - clusters with relatively static sets of roles), but a future wdrf patch will add http endpoints to add, remove, and update roles. This patch also enforces that frameworks register with valid role (this won't affect people who don't care about roles, since there's always the "*" role, which is the default for frameworks that don't specify a role). Diffs ----- include/mesos/mesos.proto 1c242d6 src/master/allocator.hpp b68b67d src/master/flags.hpp 8481baa src/master/hierarchical_allocator_process.hpp 2422fbd src/master/master.hpp d3790dc src/master/master.cpp 3207157 src/tests/allocator_tests.cpp 540c05a src/tests/allocator_zookeeper_tests.cpp 2c7deb1 src/tests/resource_offers_tests.cpp 5e53a89 src/tests/utils.hpp ca3ecd7 Diff: https://reviews.apache.org/r/11206/diff/ Testing ------- make check Thanks, Thomas Marshall
