----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11206/ -----------------------------------------------------------
(Updated June 5, 2013, 9:21 p.m.) Review request for mesos and Benjamin Hindman. Changes ------- Updated from discussion with Ben H: added a weights command line flag to master so that masters can start with role weights already set. Description ------- Previously when we were doing hierarchical allocation by user, we created and removed user pools for allocation based on what users had frameworks currently running in the cluster. However, with the role abstraction it makes sense to have more persistence than that, especially once we add weights - if you set the weight for a role, you want the allocator to remember it even if there aren't any frameworks for that role currently running. So, I decided that it made sense to create a concept of specific roles that are allowable in the cluster. With this patch, its only possible to pass roles in to the master as a command line flag (to ease what I assume will be the common case - clusters with relatively static sets of roles), but a future wdrf patch will add http endpoints to add, remove, and update roles. This patch also enforces that frameworks register with valid role (this won't affect people who don't care about roles, since there's always the "*" role, which is the default for frameworks that don't specify a role). Diffs (updated) ----- include/mesos/mesos.proto ece6559 src/master/allocator.hpp 78c75bb src/master/flags.hpp f4ce8c1 src/master/hierarchical_allocator_process.hpp 1048a28 src/master/master.hpp 8e7b74c src/master/master.cpp a2e4b90 src/tests/allocator_tests.cpp 32f0a90 src/tests/allocator_zookeeper_tests.cpp 1daaecd src/tests/mesos.hpp fca41aa src/tests/resource_offers_tests.cpp 3d5f02d Diff: https://reviews.apache.org/r/11206/diff/ Testing ------- make check Thanks, Thomas Marshall
