----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11126/#review20719 -----------------------------------------------------------
src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/11126/#comment42784> Thanks for catching this bug! How about we only create the nested "test" cgroup if it doesn't exist instead? - Vinod Kone On May 14, 2013, 5:57 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11126/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 5:57 p.m.) > > > Review request for mesos. > > > Description > ------- > > From 77d14cc85e6378339f3937f2b5057798927d93f2 Mon Sep 17 00:00:00 2001 > From: Brenden Matthews <[email protected]> > Date: Fri, 3 May 2013 10:02:44 -0700 > Subject: [PATCH 19/24] Make sure you clean up the cgroups test. > > Sometimes the cgroup test fails because the directory is already there. > This should ensure that it gets cleanup up in that case before we exit. > > Review: https://reviews.apache.org/r/11126 > --- > src/slave/cgroups_isolator.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > > Diffs > ----- > > src/slave/cgroups_isolator.cpp 17a68dfc24969e466d22ebc4be0d89af86e028a6 > > Diff: https://reviews.apache.org/r/11126/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
