> On June 3, 2013, 8:50 p.m., Vinod Kone wrote: > > src/slave/cgroups_isolator.cpp, line 339 > > <https://reviews.apache.org/r/11126/diff/5/?file=300089#file300089line339> > > > > This comment needs to be rephrased/killed. The nested cgroup might've > > been created just above.
Good catch. You're so very thorough :) - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11126/#review21355 ----------------------------------------------------------- On June 3, 2013, 7 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11126/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 7 p.m.) > > > Review request for mesos. > > > Description > ------- > > Make sure you clean up the cgroups test. > > Sometimes the cgroup test fails because the directory is already there. > This should ensure that it gets cleanup up in that case before we exit. > > We'll also check that it exists before we try creating it. If it > already exists, we'll skip the creation. > > Review: https://reviews.apache.org/r/11126 > > > Diffs > ----- > > src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d > > Diff: https://reviews.apache.org/r/11126/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
