> On June 3, 2013, 6:32 p.m., Vinod Kone wrote: > > src/slave/cgroups_isolator.cpp, lines 323-325 > > <https://reviews.apache.org/r/11126/diff/3/?file=300040#file300040line323> > > > > What is the update here? Can you check the existence before create as I > > commented earlier? > > Brenden Matthews wrote: > I didn't address that issue yet. I was just fixing post-reviews and > rebasing. I'll update this shortly.
I update the patch, though you still need to remove the cgroup before calling exit(). - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11126/#review21344 ----------------------------------------------------------- On June 3, 2013, 5:56 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11126/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 5:56 p.m.) > > > Review request for mesos. > > > Description > ------- > > Make sure you clean up the cgroups test. > > Sometimes the cgroup test fails because the directory is already there. > This should ensure that it gets cleanup up in that case before we exit. > > Review: https://reviews.apache.org/r/11126 > > > Diffs > ----- > > src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d > > Diff: https://reviews.apache.org/r/11126/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
