----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11710/#review21776 -----------------------------------------------------------
3rdparty/libprocess/include/process/help.hpp <https://reviews.apache.org/r/11710/#comment44974> should this have a header too? 3rdparty/libprocess/include/process/help.hpp <https://reviews.apache.org/r/11710/#comment44988> can we have helpers for these too? all these symbols are overwhelming for someone who doesn't understand markdown. 3rdparty/libprocess/include/process/help.hpp <https://reviews.apache.org/r/11710/#comment44990> how about using strings::contains/startsWith here? 3rdparty/libprocess/include/process/help.hpp <https://reviews.apache.org/r/11710/#comment44991> s/using// 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/11710/#comment44993> I actually like the current format, especially for DESCRIPTION. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/11710/#comment44992> s/uses,/uses/ ? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/11710/#comment44994> strings::contains() ? - Vinod Kone On June 7, 2013, 5:51 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11710/ > ----------------------------------------------------------- > > (Updated June 7, 2013, 5:51 p.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > Help! I need somebody. HELP! Not just anybody. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 9facdd99e502e6d0470ef3bb5715c88a4562dd20 > 3rdparty/libprocess/include/process/help.hpp PRE-CREATION > 3rdparty/libprocess/include/process/logging.hpp > cba2fd4b52f1aeaa2cd9538ded431c7850c2fe2a > 3rdparty/libprocess/include/process/process.hpp > e70b4f7c521658443c84578876fb4d9a30688b03 > 3rdparty/libprocess/include/process/profiler.hpp > 64cf6224a73a5f4ec26050e9e62c7bc4a0cea1f7 > 3rdparty/libprocess/src/process.cpp > 3ffe0b52b9981d1666d53a0f2d62f9aba6f0a969 > 3rdparty/libprocess/src/statistics.cpp > d8f5ad10434f0cf4110e399db7c07f14810fae60 > 3rdparty/libprocess/src/tests/http_tests.cpp > f6772674e2fd795b92c7ea787fa41e12f8af6fc2 > > Diff: https://reviews.apache.org/r/11710/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
