> On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > I'm confused as to why you decided to expose the Help process in include? > > Was it out of necessity? It seems like we would want to hide the Help > > Process and only use it internally.
I just followed convention of a few other files, including gc.hpp and profiler.hpp. In the end, I think it's nice to see other examples of processes. If users end up attempting to spawn these themselves (without looking for the return value of 'spawn') then we can consider moving these all into *.cpp files. > On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 24 > > <https://reviews.apache.org/r/11710/diff/1/?file=301808#file301808line24> > > > > If you're only needing 1-2 levels of headers, I find the Setext header > > format more readable in the text form, but I believe you only get h1 and h2. > > > > See: http://daringfireball.net/projects/markdown/syntax#header I also like the the Setext header format, but I thought the headers were too big. I swapped for putting '###' on each side to make it more readable for non-markdown folks (e.g., '### TL;DR; ###'). > On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/help.hpp, lines 45-46 > > <https://reviews.apache.org/r/11710/diff/1/?file=301808#file301808line45> > > > > seems like keeping the newlines on the same line makes more sense and > > would read better: > > > > tldr + "\n" + > > "### USAGE\n" + The point was to make the formatted code read like how you'd see it via curl or in a web page. There is already supposed to be a newline after 'tldr' but we want another newline between it and the usage header. I updated the code though to make sure that all of 'tldr', 'usage', and 'description' end with a newline. > On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 159 > > <https://reviews.apache.org/r/11710/diff/1/?file=301808#file301808line159> > > > > Not handling >2 as a bad request? Great idea, done! > On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 229 > > <https://reviews.apache.org/r/11710/diff/1/?file=301808#file301808line229> > > > > Do you want this html to contain newlines for readability in the page > > source? Adding all the newlines clutters the code and anyone using a browser will be able to see this HTML pretty printed (e.g., via Chrome developer tools). > On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/logging.hpp, line 104 > > <https://reviews.apache.org/r/11710/diff/1/?file=301809#file301809line104> > > > > It's too bad you can't initialize it in this file.. C++11! > On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 278 > > <https://reviews.apache.org/r/11710/diff/1/?file=301808#file301808line278> > > > > map because you want ordered, right? Yup. > On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, line 418 > > <https://reviews.apache.org/r/11710/diff/1/?file=301812#file301812line418> > > > > Ah I see this is one character shy of fitting on one line! Then I'm > > guessing you continued the trend, but I think the others read easier > > without the unnecessary newlines. Actually, I was trying to get output that kind of looked like the finished product, i.e., with the formatting with the header on one line and then the text on the next line. > On June 11, 2013, 5:34 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 440-443 > > <https://reviews.apache.org/r/11710/diff/1/?file=301812#file301812line440> > > > > Why the newlines? See previous comment. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11710/#review21689 ----------------------------------------------------------- On June 7, 2013, 5:51 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11710/ > ----------------------------------------------------------- > > (Updated June 7, 2013, 5:51 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Help! I need somebody. HELP! Not just anybody. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 9facdd99e502e6d0470ef3bb5715c88a4562dd20 > 3rdparty/libprocess/include/process/help.hpp PRE-CREATION > 3rdparty/libprocess/include/process/logging.hpp > cba2fd4b52f1aeaa2cd9538ded431c7850c2fe2a > 3rdparty/libprocess/include/process/process.hpp > e70b4f7c521658443c84578876fb4d9a30688b03 > 3rdparty/libprocess/include/process/profiler.hpp > 64cf6224a73a5f4ec26050e9e62c7bc4a0cea1f7 > 3rdparty/libprocess/src/process.cpp > 3ffe0b52b9981d1666d53a0f2d62f9aba6f0a969 > 3rdparty/libprocess/src/statistics.cpp > d8f5ad10434f0cf4110e399db7c07f14810fae60 > 3rdparty/libprocess/src/tests/http_tests.cpp > f6772674e2fd795b92c7ea787fa41e12f8af6fc2 > > Diff: https://reviews.apache.org/r/11710/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
