> On June 12, 2013, 6:13 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 33 > > <https://reviews.apache.org/r/11710/diff/1/?file=301808#file301808line33> > > > > should this have a header too?
Nope, this is just a list, this doesn't actually get rendered into anything. > On June 12, 2013, 6:13 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/help.hpp, lines 172-173 > > <https://reviews.apache.org/r/11710/diff/1/?file=301808#file301808line172> > > > > can we have helpers for these too? all these symbols are overwhelming > > for someone who doesn't understand markdown. I think adding a markdown.hpp would be great, but I'm not going to take that on right now. ;) > On June 12, 2013, 6:13 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/process.cpp, line 418 > > <https://reviews.apache.org/r/11710/diff/1/?file=301812#file301812line418> > > > > I actually like the current format, especially for DESCRIPTION. Awesome! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11710/#review21776 ----------------------------------------------------------- On June 7, 2013, 5:51 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11710/ > ----------------------------------------------------------- > > (Updated June 7, 2013, 5:51 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Help! I need somebody. HELP! Not just anybody. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 9facdd99e502e6d0470ef3bb5715c88a4562dd20 > 3rdparty/libprocess/include/process/help.hpp PRE-CREATION > 3rdparty/libprocess/include/process/logging.hpp > cba2fd4b52f1aeaa2cd9538ded431c7850c2fe2a > 3rdparty/libprocess/include/process/process.hpp > e70b4f7c521658443c84578876fb4d9a30688b03 > 3rdparty/libprocess/include/process/profiler.hpp > 64cf6224a73a5f4ec26050e9e62c7bc4a0cea1f7 > 3rdparty/libprocess/src/process.cpp > 3ffe0b52b9981d1666d53a0f2d62f9aba6f0a969 > 3rdparty/libprocess/src/statistics.cpp > d8f5ad10434f0cf4110e399db7c07f14810fae60 > 3rdparty/libprocess/src/tests/http_tests.cpp > f6772674e2fd795b92c7ea787fa41e12f8af6fc2 > > Diff: https://reviews.apache.org/r/11710/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
