----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11847/#review21818 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/11847/#comment45013> Do you want return error for group <= 0? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/11847/#comment45014> ditto 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/11847/#comment45015> no need for getpid(). 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/11847/#comment45016> ditto - Vinod Kone On June 12, 2013, 7:44 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11847/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 7:44 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This was particularly useful for my upcoming killtree change. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 047778d05ebbbefd85e4a163dbb6ab8445edfb7f > > Diff: https://reviews.apache.org/r/11847/diff/ > > > Testing > ------- > > Added basic tests for now. Benh and I were discussing creating a nice > abstraction for generating process trees that will make testing simpler. > > > Thanks, > > Ben Mahler > >
