> On June 15, 2013, 10:45 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 373 > > <https://reviews.apache.org/r/11847/diff/1/?file=304300#file304300line373> > > > > To keep the constants first, maybe 'EXPECT_LE(1u, groupe.get().size())'?
Then we'd be doing 'Yoda' comparisons, which unfortunately is how EXPECT_EQ works. =/ > On June 15, 2013, 10:45 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 1070 > > <https://reviews.apache.org/r/11847/diff/1/?file=304299#file304299line1070> > > > > I'd also be okay with the semantics that a group < 0 just returns an > > empty set (because 'process.group == group' will never be true right?). Turns out on OSX there are issues with groups and sessions! So leaving as Error(): [ RUN ] OsTest.killtree Performing killtree operation on 55769 Stopped 55769 Children of 55769: { 55770 } Members of group 55769: { 55769, 55770, 55771 } Members of session 55769: { 55769, 55771 } Stopped 55770 Children of 55770: { } Members of group -1: { } Members of session -1: { 1830, 5421, 5831, 6078, 55770 } Stopped 55771 Children of 55771: { 55772 } Members of group 55769: { 55769, 55770, 55771 } Members of session 55769: { 55769, 55771 } Stopped 1830 Children of 1830: { } Members of group -1: { } Members of session -1: { 1830, 5421, 5831, 6078, 55770 } Stopped 5421 Children of 5421: { } Members of group -1: { } Members of session -1: { 1830, 5421, 5831, 6078, 55770 } Stopped 5831 Children of 5831: { } Members of group -1: { } Members of session -1: { 1830, 5421, 5831, 6078, 55770 } Stopped 6078 Children of 6078: { } Members of group -1: { } Members of session -1: { 1830, 5421, 5831, 6078, 55770 } Stopped 55772 Children of 55772: { } Members of group 55772: { 55772 } Members of session 55772: { 55772 } Signaled 1830 Signaled 5421 Signaled 5831 Signaled 6078 Signaled 55769 Signaled 55770 Signaled 55771 Signaled 55772 > On June 15, 2013, 10:45 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 383 > > <https://reviews.apache.org/r/11847/diff/1/?file=304300#file304300line383> > > > > To keep the constants first, maybe 'EXPECT_LE(1u, groupe.get().size())'? Ditto. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11847/#review21949 ----------------------------------------------------------- On June 18, 2013, 4:41 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11847/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 4:41 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This was particularly useful for my upcoming killtree change. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 73b2336e93d6e5aac97e2c18e8e36c258c56a420 > > Diff: https://reviews.apache.org/r/11847/diff/ > > > Testing > ------- > > Added basic tests for now. Benh and I were discussing creating a nice > abstraction for generating process trees that will make testing simpler. > > > Thanks, > > Ben Mahler > >
