> On June 18, 2013, 6:17 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 266 > > <https://reviews.apache.org/r/11847/diff/2/?file=307480#file307480line266> > > > > Eh, I'd make 'pids' not be const& above and reuse it here and below > > where you get pids for a particular session.
Thanks, I should have cleaned this up when I merged the code from the other tests in here! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11847/#review22050 ----------------------------------------------------------- On June 18, 2013, 4:41 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11847/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 4:41 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This was particularly useful for my upcoming killtree change. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 73b2336e93d6e5aac97e2c18e8e36c258c56a420 > > Diff: https://reviews.apache.org/r/11847/diff/ > > > Testing > ------- > > Added basic tests for now. Benh and I were discussing creating a nice > abstraction for generating process trees that will make testing simpler. > > > Thanks, > > Ben Mahler > >
