----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11720/#review21826 -----------------------------------------------------------
This looks great except for some tests for parse. include/mesos/mesos.proto <https://reviews.apache.org/r/11720/#comment45089> Even this sentence makes s/dedication/reservation/ make more sense. Let's do it! :-) src/common/dedications.cpp <https://reviews.apache.org/r/11720/#comment45090> Formatting. src/common/dedications.cpp <https://reviews.apache.org/r/11720/#comment45091> Formatting. src/slave/flags.hpp <https://reviews.apache.org/r/11720/#comment45093> I never liked the delimiters I picked for resources, and this is getting pretty complicated too. What about using JSON to describe these things instead? For example: --resources='{ "cpus": 24.0, "disks": [disk1, disk2], "ports": "[3000-4000]", ... }' --reservations='{ "role1": { "cpus": 14.0, "disks": [disk1], "ports": "[3000-3500]", ... }, "role2": { "cpus": 10.0, "disks": [disk2], "ports": "[3501-4000]", ...}}' The caveat here is that we'd have to represent "ranges" as a string since you can't natively represent that in JSON without an object (IIUC). Thoughts? We should punt this for now anyway since we don't have a JSON parsing library. But it probably makes sense to clean this up for 1.0 and we might even be able to get to it for 0.14.0. Want to create an issue? - Benjamin Hindman On June 12, 2013, 11:39 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11720/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 11:39 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > This patch adds a Dedication protobuf, Dedications field to SlaveInfo, > Dedications class with a parse function, and a dedication command line flag > to the slave. > > > This addresses bug MESOS-505. > https://issues.apache.org/jira/browse/MESOS-505 > > > Diffs > ----- > > include/mesos/mesos.proto ece6559 > src/Makefile.am e67b342 > src/common/dedications.hpp PRE-CREATION > src/common/dedications.cpp PRE-CREATION > src/slave/flags.hpp 9612983 > src/slave/slave.hpp 26dc96e > src/slave/slave.cpp 8ce1646 > > Diff: https://reviews.apache.org/r/11720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
