> On June 19, 2013, 4:16 a.m., Vinod Kone wrote: > > Can you update the "==" operator for SlaveInfo in type_utils.hpp, to > > compare Reservations too? You would likely need to implement this operator > > for Reservations.
Also, for future developers, would you mind adding a comment on a top of SlaveInfo in mesos.proto saying that any new field should be similarly accounted for when comparing SlaveInfo? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11720/#review22102 ----------------------------------------------------------- On June 14, 2013, 1:35 a.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11720/ > ----------------------------------------------------------- > > (Updated June 14, 2013, 1:35 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > This patch adds a Dedication protobuf, Dedications field to SlaveInfo, > Dedications class with a parse function, and a dedication command line flag > to the slave. > > > This addresses bug MESOS-505. > https://issues.apache.org/jira/browse/MESOS-505 > > > Diffs > ----- > > include/mesos/mesos.proto 8cbcd9a > src/Makefile.am e67b342 > src/common/reservations.hpp PRE-CREATION > src/common/reservations.cpp PRE-CREATION > src/slave/flags.hpp 9612983 > src/slave/slave.hpp d1ba82e > src/slave/slave.cpp b5b7e0e > > Diff: https://reviews.apache.org/r/11720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
