> On June 13, 2013, 12:50 a.m., Benjamin Hindman wrote: > > src/slave/flags.hpp, line 54 > > <https://reviews.apache.org/r/11720/diff/1/?file=301978#file301978line54> > > > > I never liked the delimiters I picked for resources, and this is > > getting pretty complicated too. What about using JSON to describe these > > things instead? For example: > > > > --resources='{ "cpus": 24.0, "disks": [disk1, disk2], "ports": > > "[3000-4000]", ... }' > > > > --reservations='{ "role1": { "cpus": 14.0, "disks": [disk1], "ports": > > "[3000-3500]", ... }, "role2": { "cpus": 10.0, "disks": [disk2], "ports": > > "[3501-4000]", ...}}' > > > > The caveat here is that we'd have to represent "ranges" as a string > > since you can't natively represent that in JSON without an object (IIUC). > > > > Thoughts? We should punt this for now anyway since we don't have a JSON > > parsing library. But it probably makes sense to clean this up for 1.0 and > > we might even be able to get to it for 0.14.0. Want to create an issue? > >
Another idea would be to use the protobuf text format. Either way, the current resource format isn't great, which is why I needed to do this: https://reviews.apache.org/r/11487/ - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11720/#review21826 ----------------------------------------------------------- On June 12, 2013, 11:39 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11720/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 11:39 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > This patch adds a Dedication protobuf, Dedications field to SlaveInfo, > Dedications class with a parse function, and a dedication command line flag > to the slave. > > > This addresses bug MESOS-505. > https://issues.apache.org/jira/browse/MESOS-505 > > > Diffs > ----- > > include/mesos/mesos.proto ece6559 > src/Makefile.am e67b342 > src/common/dedications.hpp PRE-CREATION > src/common/dedications.cpp PRE-CREATION > src/slave/flags.hpp 9612983 > src/slave/slave.hpp 26dc96e > src/slave/slave.cpp 8ce1646 > > Diff: https://reviews.apache.org/r/11720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
