-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11813/#review21834
-----------------------------------------------------------


Did you test this out?


src/webui/master/static/controllers.js
<https://reviews.apache.org/r/11813/#comment45105>

    PIDs look like the following:
    <string>@<ip>:<port>
    
    so s/indexOf/lastIndexOf/ just to be safe, here and in the other lines 
above.


- Ben Mahler


On June 12, 2013, 2:20 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11813/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 2:20 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Use slave hostname rather than libprocess address for webui.
> 
> Review: https://reviews.apache.org/r/11813
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/controllers.js 
> 0ea77cec2d6ca520e69fd74eb56fe05d32b711bd 
> 
> Diff: https://reviews.apache.org/r/11813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>

Reply via email to