> On June 13, 2013, 1:45 a.m., Ben Mahler wrote: > > src/webui/master/static/controllers.js, line 726 > > <https://reviews.apache.org/r/11813/diff/2/?file=303950#file303950line726> > > > > PIDs look like the following: > > <string>@<ip>:<port> > > > > so s/indexOf/lastIndexOf/ just to be safe, here and in the other lines > > above.
Good idea. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11813/#review21834 ----------------------------------------------------------- On June 13, 2013, 4:37 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11813/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 4:37 p.m.) > > > Review request for mesos. > > > Description > ------- > > WebUI: Use slave hostname rather than libprocess. > > It's safer to use the hostname of the slave rather than the libprocess > IP since we don't necessarily know that the interface's IP is publicly > accessible. This applies especially for services like EC2. > > Review: https://reviews.apache.org/r/11813 > > > Diffs > ----- > > src/webui/master/static/controllers.js > 0ea77cec2d6ca520e69fd74eb56fe05d32b711bd > > Diff: https://reviews.apache.org/r/11813/diff/ > > > Testing > ------- > > Tested by test-driving the web UI. > > > Thanks, > > Brenden Matthews > >
