----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11813/#review21863 -----------------------------------------------------------
Ship it! Looks good modulo the indents on the latest diff. If you're looking for a quick way to test out webui changes, "mesos-local.sh --num_slaves=2" works nicely, for example. src/webui/master/static/controllers.js <https://reviews.apache.org/r/11813/#comment45144> bad indent src/webui/master/static/controllers.js <https://reviews.apache.org/r/11813/#comment45145> ditto src/webui/master/static/controllers.js <https://reviews.apache.org/r/11813/#comment45146> ditto - Ben Mahler On June 13, 2013, 4:37 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11813/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 4:37 p.m.) > > > Review request for mesos. > > > Description > ------- > > WebUI: Use slave hostname rather than libprocess. > > It's safer to use the hostname of the slave rather than the libprocess > IP since we don't necessarily know that the interface's IP is publicly > accessible. This applies especially for services like EC2. > > Review: https://reviews.apache.org/r/11813 > > > Diffs > ----- > > src/webui/master/static/controllers.js > 0ea77cec2d6ca520e69fd74eb56fe05d32b711bd > > Diff: https://reviews.apache.org/r/11813/diff/ > > > Testing > ------- > > Tested by test-driving the web UI. > > > Thanks, > > Brenden Matthews > >
