----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12010/#review22174 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/12010/#comment45568> Seems like all this constructor logic should move into initialize() so that we don't create the work directory until a slave is spawned, but seems fine for now. - Ben Mahler On June 20, 2013, 5:26 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12010/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 5:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/slave.cpp 952bd149247c2cc44b87d20fe63a45d011f5578b > > Diff: https://reviews.apache.org/r/12010/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
