> On June 20, 2013, 11:16 p.m., Ben Mahler wrote: > > I see why you added the helper, but it seems odd that it's only needed / > > used by initialization. I realize initialize is fairly large, but my > > preference would be to keep it in there. Alternatively, could the helper be > > static, taking as input the flags, and returning a Resources object?
I really don't want to put it up in initialize(), because as you noted, its ~200 lines already! I think it reads pretty clear when you see it in initialize(). Infact, I would even like all the installs to be refactored into something like setupRoutes(). Regarding a static helper, I don't understand the reasoning? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12010/#review22208 ----------------------------------------------------------- On June 20, 2013, 11:02 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12010/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 11:02 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/slave.hpp d1ba82ed0c87331c6c06b109bbc2b267a07cf335 > src/slave/slave.cpp 952bd149247c2cc44b87d20fe63a45d011f5578b > > Diff: https://reviews.apache.org/r/12010/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
