> On June 20, 2013, 5:38 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 116-118 > > <https://reviews.apache.org/r/12010/diff/1/?file=309582#file309582line116> > > > > Seems like all this constructor logic should move into initialize() so > > that we don't create the work directory until a slave is spawned, but seems > > fine for now.
refactored the resources setup into 'setupResources()' that is called from initialize. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12010/#review22174 ----------------------------------------------------------- On June 20, 2013, 5:26 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12010/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 5:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/slave.cpp 952bd149247c2cc44b87d20fe63a45d011f5578b > > Diff: https://reviews.apache.org/r/12010/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
