> On June 25, 2013, 6:04 a.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp, line 29
> > <https://reviews.apache.org/r/12073/diff/1/?file=310710#file310710line29>
> >
> > We'll need to include <stout/os.hpp>, so that this will compile were
> > someone to only include this header.
I couldn't. After I added stout/os.hpp in proc.hpp, possibly due to circular
header includes (proc.hpp -> os.hpp -> linux.hpp -> proc.hpp) , error occurs
while compiling proc_test.cpp (which includes proc.hpp):
linux.hpp:39: error: ‘proc’ was not declared in this scope
So I used forward declaration:
namespace os {
bool exists(const std::string& path); // Forward declaration.
}
> On June 25, 2013, 6:04 a.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, lines 587-589
> > <https://reviews.apache.org/r/12073/diff/1/?file=310711#file310711line587>
> >
> > Have you tested this on OS X?
Yes.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12073/#review22346
-----------------------------------------------------------
On June 25, 2013, 4:45 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12073/
> -----------------------------------------------------------
>
> (Updated June 25, 2013, 4:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: mesos-520
> https://issues.apache.org/jira/browse/mesos-520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
> 0e37ca00fd14175f8d6ec7b37f41fdf32919472e
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp
> 632f95fa71cac6aa4fa61fefc4232ed83bc5e6d5
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp
> f2d241a2c03775f52f675e6b87c47669b99f4149
> 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp
> 0bb1b1aae63740251a88a49085dc7cf66a4a8e18
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
> 2ac9030247b1c5dcd8b1b83fd87f8b929b34cdcb
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
> 56804ecc09fb09dddeeededa9d0aab6cc9e5dd23
>
> Diff: https://reviews.apache.org/r/12073/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="ReaperTest.*" --gtest_repeat=1000
> --gtest_break_on_failure
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
