> On June 26, 2013, 5:37 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp, line 29 > > <https://reviews.apache.org/r/12073/diff/1/?file=310710#file310710line29> > > > > Ah, I meant both the os.hpp include and the forward declaration. See > > killtree.hpp for example. Let me know if that works!
Separated out os::exists from os.hpp to stout/os/exists.hpp > On June 26, 2013, 5:37 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp, line 154 > > <https://reviews.apache.org/r/12073/diff/1/?file=310710#file310710line154> > > > > s/doesn't/does not/ I realized that I have been apostrophes a lot in the past and it's probably not worthwhile to go back and edit them. So I'll make the changes where you pointed out follow the rule in the future. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12073/#review22407 ----------------------------------------------------------- On June 26, 2013, 10:27 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12073/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 10:27 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: mesos-520 > https://issues.apache.org/jira/browse/mesos-520 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 99a393473491ef5d073c18bc94f8fc2e39a40845 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 0e37ca00fd14175f8d6ec7b37f41fdf32919472e > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > 632f95fa71cac6aa4fa61fefc4232ed83bc5e6d5 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > f2d241a2c03775f52f675e6b87c47669b99f4149 > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > 0bb1b1aae63740251a88a49085dc7cf66a4a8e18 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 2ac9030247b1c5dcd8b1b83fd87f8b929b34cdcb > 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp > 56804ecc09fb09dddeeededa9d0aab6cc9e5dd23 > src/linux/cgroups.cpp 5d63bde54b458e2067b9119383b3fe042c1874de > src/slave/cgroups_isolator.cpp 9d188866aa63163622093b668595804d99f46398 > src/slave/paths.hpp 9d2a2a40048bbe594723ba3f19aa10eaf1935926 > src/slave/slave.cpp 9985f14467ca0aa7faf83e602e1d8f1c2219dfc0 > src/slave/state.cpp 27a2731cf760f65bd90fefd38715654a63017345 > src/tests/environment.cpp 144480dc06549c0fc3489079ccf0685a7d43f8a0 > src/tests/gc_tests.cpp 174580086370f61be369f7a212d62531e87e6f01 > src/tests/isolator_tests.cpp a37f006aa9c7883a4db942a49517fd66cd34bbb4 > src/tests/slave_recovery_tests.cpp 0195e688dac09b139c107e6815e0b842116c5e5c > > Diff: https://reviews.apache.org/r/12073/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter="ReaperTest.*" --gtest_repeat=1000 > --gtest_break_on_failure > > > Thanks, > > Jiang Yan Xu > >
