----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12073/#review22407 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp <https://reviews.apache.org/r/12073/#comment45926> Ah, I meant both the os.hpp include and the forward declaration. See killtree.hpp for example. Let me know if that works! 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp <https://reviews.apache.org/r/12073/#comment45927> s/doesn't/does not/ - Ben Mahler On June 26, 2013, 6:39 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12073/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 6:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: mesos-520 > https://issues.apache.org/jira/browse/mesos-520 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 0e37ca00fd14175f8d6ec7b37f41fdf32919472e > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > 632f95fa71cac6aa4fa61fefc4232ed83bc5e6d5 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > f2d241a2c03775f52f675e6b87c47669b99f4149 > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > 0bb1b1aae63740251a88a49085dc7cf66a4a8e18 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 2ac9030247b1c5dcd8b1b83fd87f8b929b34cdcb > 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp > 56804ecc09fb09dddeeededa9d0aab6cc9e5dd23 > > Diff: https://reviews.apache.org/r/12073/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter="ReaperTest.*" --gtest_repeat=1000 > --gtest_break_on_failure > > > Thanks, > > Jiang Yan Xu > >
